OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Fix ExpandedNodeId.Format output for not well formed uri and JSON Verbose WriteStatusCode #2794

Closed mregen closed 1 month ago

mregen commented 1 month ago

Proposed changes

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.95%. Comparing base (9c7b321) to head (a588ce3). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2794 +/- ## ========================================== - Coverage 55.40% 54.95% -0.46% ========================================== Files 349 349 Lines 66055 66076 +21 Branches 13549 13553 +4 ========================================== - Hits 36597 36309 -288 - Misses 25572 25833 +261 - Partials 3886 3934 +48 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.