codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
Project coverage is 57.23%. Comparing base (
cb621df) to head (3672ebe). Report is 2 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| Stack/Opc.Ua.Core/Types/Encoders/BinaryDecoder.cs | 0.00% | 0 Missing and 25 partials :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #2804 +/- ## ========================================== + Coverage 55.31% 57.23% +1.91% ========================================== Files 349 352 +3 Lines 66056 75520 +9464 Branches 13549 15988 +2439 ========================================== + Hits 36541 43223 +6682 - Misses 25631 27870 +2239 - Partials 3884 4427 +543 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
… (#2798)
The server under test has a extension object with a complex type. Type id = {nsu=http://opcfoundation.org/UA/Machinery/Result/;i=5008}. This contains something with a variant array that is null though (-1). SetProperty should support setting a Array that is null. Therefore, test for null collection (case when length was encoded as -1) before dereferencing ahead of the ToArrray() conversion to Array.
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...