OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

IOP: Fix FetchOperationLimits for some use cases #2807

Closed mregen closed 4 weeks ago

mregen commented 4 weeks ago

Proposed changes

In this case operation limits were ignored and other BadTooManyOperations errors may be returned because default operation limits were used.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.82%. Comparing base (3672ebe) to head (ea5bd15). Report is 2 commits behind head on develop/main374.

Files with missing lines Patch % Lines
Libraries/Opc.Ua.Client/Session/Session.cs 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop/main374 #2807 +/- ## =================================================== - Coverage 57.23% 54.82% -2.41% =================================================== Files 352 349 -3 Lines 75520 66056 -9464 Branches 15988 13574 -2414 =================================================== - Hits 43223 36216 -7007 + Misses 27870 25875 -1995 + Partials 4427 3965 -462 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.