OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

Update brokerHostName with configured value before MqttClientOptionsBuilder uses it #2815

Closed mrsuciu closed 3 weeks ago

mrsuciu commented 3 weeks ago

Proposed changes

MqttClientOptionsBuilder now uses the configured value and overrides the "localhost" default value of the brokerHostName.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 73.93939% with 473 lines in your changes missing coverage. Please review.

Project coverage is 55.32%. Comparing base (3672ebe) to head (1508c56). Report is 4 commits behind head on develop/main374.

Files with missing lines Patch % Lines
...tack/Opc.Ua.Core/Security/Certificates/EccUtils.cs 70.96% 49 Missing and 32 partials :warning:
...ore/Security/Certificates/CertificateIdentifier.cs 45.88% 41 Missing and 5 partials :warning:
...c.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Symmetric.cs 71.85% 31 Missing and 7 partials :warning:
Libraries/Opc.Ua.Client/Session/Session.cs 68.46% 24 Missing and 11 partials :warning:
Stack/Opc.Ua.Core/Security/Certificates/Nonce.cs 79.47% 19 Missing and 12 partials :warning:
....Ua.Core/Stack/Tcp/UaSCBinaryChannel.Asymmetric.cs 64.61% 15 Missing and 8 partials :warning:
.../Security/Certificates/CertificateTypesProvider.cs 67.85% 9 Missing and 9 partials :warning:
...Core/Security/Certificates/CertificateValidator.cs 82.35% 15 Missing and 3 partials :warning:
...a.Core/Security/Certificates/CertificateFactory.cs 39.28% 11 Missing and 6 partials :warning:
...raries/Opc.Ua.Configuration/ApplicationInstance.cs 76.11% 10 Missing and 6 partials :warning:
... and 26 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop/main374 #2815 +/- ## =================================================== - Coverage 57.23% 55.32% -1.92% =================================================== Files 352 352 Lines 75520 67337 -8183 Branches 15988 13809 -2179 =================================================== - Hits 43223 37253 -5970 + Misses 27870 25999 -1871 + Partials 4427 4085 -342 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mregen commented 3 weeks ago

@mrsuciu, please rebase on main374