Closed mrsuciu closed 3 weeks ago
Attention: Patch coverage is 73.93939%
with 473 lines
in your changes missing coverage. Please review.
Project coverage is 55.32%. Comparing base (
3672ebe
) to head (1508c56
). Report is 4 commits behind head on develop/main374.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mrsuciu, please rebase on main374
Proposed changes
MqttClientOptionsBuilder now uses the configured value and overrides the "localhost" default value of the brokerHostName.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...