OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

add auto accept untrusted certificates for GetIssuerNoExceptionAsync … #2822

Closed KircMax closed 3 weeks ago

KircMax commented 3 weeks ago

Use AutoAcceptUntrustedCertificates in GetIssuerNoExceptionAsync to always get the issuers when not caring about the trust relation.

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

KircMax commented 3 weeks ago

with the adjustment the issuers are loaded: image

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.07%. Comparing base (b2d715d) to head (a86af6a).

Files with missing lines Patch % Lines
...Core/Security/Certificates/CertificateValidator.cs 66.66% 1 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2822 +/- ## ========================================== - Coverage 55.70% 55.07% -0.63% ========================================== Files 352 352 Lines 67332 67344 +12 Branches 13806 13809 +3 ========================================== - Hits 37506 37089 -417 - Misses 25792 26171 +379 - Partials 4034 4084 +50 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.