Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
The EscapeUri method of the Utils must not change the letters within the Uri which would happen when using the Uri.TryCreate method. This will then lead to the NodeId actually having the URI
"https://ABC" being changed to "https://abc" and later when having a complex type write being "not found" when using ExpandedNodeId.ToNodeId(); (returns null)
since it is null the BinaryEncoder will throw an Exception that it wasnt found in the namespacetable and therefore the write fails.
Related Issues
Fixes #2826
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.
[x] Bugfix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking change which adds functionality)
[ ] Test enhancement (non-breaking change to increase test coverage)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
[x] I ran tests locally with my changes, all passed.
[ ] I fixed all failing tests in the CI pipelines.
[ ] I fixed all introduced issues with CodeQL and LGTM.
[ ] I have added tests that prove my fix is effective or that my feature works and increased code coverage.
[ ] I have added necessary documentation (if appropriate).
[ ] Any dependent changes have been merged and published in downstream modules.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. The EscapeUri method of the Utils must not change the letters within the Uri which would happen when using the Uri.TryCreate method. This will then lead to the NodeId actually having the URI "https://ABC" being changed to "https://abc" and later when having a complex type write being "not found" when using ExpandedNodeId.ToNodeId(); (returns null)
since it is null the BinaryEncoder will throw an Exception that it wasnt found in the namespacetable and therefore the write fails.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...