OPCFoundation / UA-.NETStandard

OPC Unified Architecture .NET Standard
Other
1.97k stars 950 forks source link

ChannelToken: Dispose HMAC and improve lifetime calculations. #2846

Closed mregen closed 21 hours ago

mregen commented 5 days ago

Proposed changes

Issues addressed:

Improvements:

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply. You can also fill these out after creating the PR.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 71.10092% with 63 lines in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (56dd06d) to head (3830a43). Report is 1 commits behind head on develop/main374.

Files with missing lines Patch % Lines
...c.Ua.Core/Stack/Tcp/UaSCBinaryChannel.Symmetric.cs 72.72% 25 Missing and 5 partials :warning:
...k/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs 51.06% 21 Missing and 2 partials :warning:
Stack/Opc.Ua.Core/Types/Utils/Utils.cs 22.22% 6 Missing and 1 partial :warning:
Stack/Opc.Ua.Core/Stack/Tcp/ChannelToken.cs 94.73% 1 Missing :warning:
Stack/Opc.Ua.Core/Stack/Tcp/TcpServerChannel.cs 90.00% 1 Missing :warning:
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs 90.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop/main374 #2846 +/- ## =================================================== - Coverage 57.28% 54.93% -2.36% =================================================== Files 352 349 -3 Lines 75539 66129 -9410 Branches 15990 13576 -2414 =================================================== - Hits 43273 36328 -6945 + Misses 27843 25843 -2000 + Partials 4423 3958 -465 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

mregen commented 3 days ago

@romanett found more issues, thanks for testing.