Open mrsuciu opened 3 days ago
Attention: Patch coverage is 18.08511%
with 77 lines
in your changes missing coverage. Please review.
Project coverage is 55.25%. Comparing base (
3672ebe
) to head (97da591
). Report is 9 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
...tack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs | 14.44% | 72 Missing and 5 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
@mrsuciu tests fail on some pipelines: The active test run was aborted. Reason: Test host process crashed : Unhandled exception.Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object. at Opc.Ua.Bindings.TcpTransportListener.OnAccept(Object sender, SocketAsyncEventArgs e) in /_/Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs:line 761 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
@mrsuciu tests fail on some pipelines: The active test run was aborted. Reason: Test host process crashed : Unhandled exception.Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object. at Opc.Ua.Bindings.TcpTransportListener.OnAccept(Object sender, SocketAsyncEventArgs e) in /_/Stack/Opc.Ua.Core/Stack/Tcp/TcpTransportListener.cs:line 761 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
@romanett This did not happen on my local runs, but somehow the test machines running the tests do not provide IP Addresses.
Hi @mrsuciu, I would only chose a less offending name than RogueClient, e.g just ClientTracker or ClientActivity etc. and make sure there are not too many info messages.
Proposed changes
Clients that behave rogue by repeatedly sending invalid messages in a certain interval of time are now tracked and blocked from connecting for a predefined amount of time. Time calculations are independent of system time.
Related Issues
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...