search

OPCFoundation / UA-Java-Legacy

This repository is provided by OPC Foundation as legacy support for an Java version for OPC UA.
https://github.com/OPCFoundation/UA-.NETStandard
Other
354 stars 226 forks source link

fix added for issue 192 #206

Closed pradeipk closed 3 years ago

pradeipk commented 4 years ago

Fix for issue https://github.com/OPCFoundation/UA-Java-Legacy/issues/192

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: pradeipk
:x: Pradeep Patel

Pradeep Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

jouniaro commented 3 years ago

This is a correct fix. But there is actually the same thing a few lines higher, which should be changed to

UnsignedInteger obj = UnsignedInteger.valueOf(m.group(1));

Could you add that to the merge request?

pradeipk commented 3 years ago

@jouniaro Changes suggested are incorporated, please have a look on the updated PR.