search

OPCODE-Open-Spring-Fest / Quant

The Automated Trading System with Risk Management is a Python application that automates trading processes, including fetching market data, executing trades based on predefined strategies, and managing orders. It incorporates robust risk management strategies to enhance trading performance and profitability.
0 stars 0 forks source link

Using String Enum Constants instead of Strings and some code formatting #5

Closed NishchayKQ closed 4 months ago

NishchayKQ commented 5 months ago

there are two commits the first commit : 44f5224f07b28cb260818b419cf5a9c665a47c01 1) is just formatting the code to match PEP-8 guidelines like blank lines after function definition 2) having imports in the order of standard library -> 3rd party, in alphabetical order

whereas the second commit (0abe004cc7548dfaeda50a263d865875d8c82f60) is Using Str Enum constants instead of Strings

closes #4

Ayushkumarsingh09 commented 5 months ago

Yeah this seems to work.

NishchayKQ commented 5 months ago

hello, is there something im missing? sorry i opened a pr without getting the issue assigned...

Ayushkumarsingh09 commented 5 months ago

Yeah, kindly from next time do mention get them assigned first,.

NishchayKQ commented 5 months ago

ok! what do i do now?