Closed gaellafond closed 2 years ago
I believe something broke in the java code. The variables sent to the dap4Contents
template are wrong. I haven't look at the code itself yet to figure out what change could have cause the issue.
However, I found a workaround to temporarily fix the issue. Instead of fixing the broken webStartService
and datasetID
variables, patch the template to output what it needs to output using other available variables. It's a dirty workaround, but it should work until a proper fix is provided.
File: /var/lib/tomcat/webapps/opendap/xsl/dap4Contents.xsl
Change
<a href="{$webStartService}/viewers?dapService={$dapService}&datasetID={$datasetID}">viewers</a>
With
<a href="/opendap/viewers/viewers?dapService={$dapService}&datasetID={../@name}{@name}">viewers</a>
Please, do NOT commit this change to the source code base. This is not an appropriate fix, it's just a workaround.
The issue is not present in the latest version: 1.16.8-51
NOTE: The file is now found in:
/home/tomcat/apache-tomcat-9.0.65/webapps/opendap/xsl/dap4Contents.xsl
Hyrax versions I'm using the
hyrax-ncwms
docker container: https://hub.docker.com/r/opendap/hyrax_ncwmsThis issue affect all versions after
1.16.4
.It is present in all the versions I have tested.
1.16.5
: I have tested:1.16.5-0
,1.16.5-287
,1.16.5-289
1.16.6
: I have tested:1.16.6-2
1.16.7
: I have tested:1.16.7-1
,1.16.7-5
,1.16.7-6
It doesn't affect version
1.16.4
and earlier.Issue The viewers link from the OPeNDAP Hyrax web page is broken, for every hosted files.
Example For the dataset
data/hdf5/grid_1_2d.h5
, the viewers URL points to:http://localhost:8080/viewers?dapService=/opendap/hyrax&datasetID=///data/hdf5/
instead ofhttp://localhost:8080/opendap/viewers/viewers?dapService=/opendap/hyrax&datasetID=/data/hdf5/grid_1_2d.h5