search

OPENDAP / libdap4

A new version of libdap that contains both DAP2 and DAP4 support
GNU Lesser General Public License v2.1
13 stars 14 forks source link

D4map fix v1 #205

Closed jgallagher59701 closed 2 years ago

jgallagher59701 commented 2 years ago

This is my first try at fixing the D4Map deep copy debacle. This is not yet been verified by running it against the BES, but it does pass the libdap tests.

jgallagher59701 commented 2 years ago

This PR does result in a BES that passes it's tests and does also pass the ObjMemCache issue by-hand test. I'm not sure how to formally test the problem, however. Maybe Kent's ticket to test the ObjMemCache will help. Should this me merged?

jgallagher59701 commented 2 years ago

Yo, I can add a test to the BES, but we won't see if that works until this is merged. However, I could write a unit test, verify that it fails without this change and that is passes with the change. My guess is that won't happen until next week unless I get very ambitious.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

0.0% 0.0% Coverage
5.3% 5.3% Duplication