kyang2014
commented
1 year ago Yes, agree. I will write a comment in the code. I tried the erase-remove pattern in my first attempt but it failed . We may need to add public methods in D4Maps class.
From: James Gallagher @.> Reply-To: OPENDAP/libdap4 @.> Date: Monday, March 13, 2023 at 11:37 AM To: OPENDAP/libdap4 @.> Cc: Kent Yang @.>, Author @.***> Subject: Re: [OPENDAP/libdap4] Hyrax 968 (PR #222)
@jgallagher59701 approved this pull request.
Lets merge this now and test it in the BES as you propose. However, I think the two loop pattern, where the inner loop calls break when an object (i.e., the map) is deleted because that delete operation invalidates the iterator used by the loop, can be replaced by the 'erase-remove' pattern. We should probably keep that in mind if we have to revisit this issue.
— Reply to this email directly, view it on GitHubhttps://github.com/OPENDAP/libdap4/pull/222#pullrequestreview-1337368560, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACOKEE3V555XVPUXAKYUPUTW345KHANCNFSM6AAAAAAVWW7Z2M. You are receiving this because you authored the thread.Message ID: @.***>
sonarcloud[bot]
remove extra maps in a local expression contraint.