Closed 7h30n3 closed 1 year ago
Map layer switcher now gets the accent color when active:
I changed that behavior to be more in line with the selected "Location" button and the small specific map layer buttons themself.
Back arrow color changed:
That's an upstream issue and doesn't persist anymore using Flutter 3.4.0
Header color changes when scrolling + no header shadow:
The changing header color is a material 3 thing, but I don't know about the missing shadow. I will take a look there.
Toggle button not correctly colored:
That's an upstream issue and doesn't persist anymore using Flutter 3.4.0
Color + unpleasant paddings in my eye, very big headline. Maybe we can tweak some of these things:
The wrong color of the toggleable is an upstream issue and doesn't persist anymore using Flutter 3.4.0 I removed some of our styling to get these dialogs more in line with material 3
Very large button with a lot of elevation. I still think that FAB is not the right choice here.
I will replace it with a filled button or tonal filled button: https://m3.material.io/components/buttons/guidelines#9ecffdb3-ef29-47e7-8d5d-f78b404fcafe
Missing shadow:
I will fix it.
Color looks brownish in contrast to the previous version or the Sidebar and Sheet:
I will fix it.
I changed that behavior to be more in line with the selected "Location" button and the small specific map layer buttons themself.
I could see this working if we had a secondary color. Then the main FAB would get the primary when active and the small FABs get the secondary color when active. But since we don't have this distinction I find it confusing that two nearby buttons share the same selection style but not the same state. The main button is just like a select box and therefore only holds an ephemeral state while the smaller buttons represent an actual state that gets saved across app restarts and that also affects how the app works, wherefore I would consider it more important.
The changing header color is a material 3 thing,
Feels unnecessary to me.
I removed some of our styling to get these dialogs more in line with material 3
The alert dialog looks off to me compared to the rest of the apps paddings/font sizes.
That's an upstream issue and doesn't persist anymore using Flutter 3.4.0
I would then delay the merge of this PR till 3.4. hits stable.
Addressed first requested changes: Still missing: