OPENER-next / OpenStop

App for collecting OpenStreetMap-compliant accessibility data in public transport
https://openstop.app
GNU General Public License v3.0
63 stars 13 forks source link

Only ask for `crossing:light` on tram crossings if `crossing:signals=no` #227

Closed wielandb closed 4 months ago

wielandb commented 6 months ago

This PR splits the condition for the crossing:light question into seperate conditions for normal and tram crossings, with the tram crossing having the additional condition that crossing:signals must be no.

wielandb commented 5 months ago

We should introduce tram questions for the following tags like we already have for highway crossings.

As far as I can see, all theese questions are already asked for tram_crossings. 🤔

Robbendebiene commented 5 months ago

In a recent PR keys and strings containing traffic light were renamed to pedestrian lights so we should move away from traffic signals here as well.

Since the warning light is not a real pedestrian light I kinda prefer "Tram crossing light signal"/ tramCrossingLightSignalName or "Tram crossing signal lights"/ tramCrossingSignalLightsName


Resolution:

So "tramCrossingTrafficSignalName": "Tram crossing traffic signal", Becomes: "tramCrossingSignalLightsName": "Tram crossing signal lights",

wielandb commented 4 months ago

Closing this in favour of the much cleaner #239