OPENER-next / OpenStop

App for collecting OpenStreetMap-compliant accessibility data in public transport
https://openstop.app
GNU General Public License v3.0
75 stars 13 forks source link

Avoid `crossing=zebra` for pedestrian crossings #241

Closed Woazboat closed 7 months ago

Woazboat commented 7 months ago

Idea

Hi, it seems like you are using crossing=zebra to tag pedestrian crossings with zebra markings. https://github.com/OPENER-next/OpenStop/blob/45672a0a3ed018bbd55cacdc5340be2041aab408/assets/question_catalog/definition.json#L2701-L2707

This tag was unfortunately introduced without going through the proposal/community approval process and has since been deprecated by the editor that introduced it. The tag itself suffer from some issues in that it clashes with the rest of the established crossing tagging scheme and has unclear semantics about the presence or absence of traffic signals.

The (recent but already very widely used) crossing:markings=* tag can be used to specify the presence and type of markings instead without any coupling to the presence of traffic signals. Complicated and error prone instructions like the one for this quest that are required as a result of mixing signals and markings will also no longer be needed. https://github.com/OPENER-next/OpenStop/blob/45672a0a3ed018bbd55cacdc5340be2041aab408/assets/question_catalog/locales/en.arb#L429

For reference, StreetComplete also only uses(/used) crossing=unmarked, crossing=marked (=crossing=uncontrolled) and crossing=traffic_signals. https://github.com/streetcomplete/StreetComplete/blob/6a294cc9952073cbfec6075387fb3dff24f1ca06/app/src/main/java/de/westnordost/streetcomplete/quests/crossing_type/CrossingType.kt

(StreetComplete recently moved to exclusively use crossing:markings=* + crossing:signals without crossing=* https://github.com/streetcomplete/StreetComplete/pull/5471)

Bug Relation

No response

Implementation

Either:

Additional Info

No response

7h30n3 commented 7 months ago

@Woazboat Thanks for bringing up th feature request. I have created a PR: https://github.com/OPENER-next/OpenStop/pull/242 adressing this request. We have decided to use the third approach, which means doing it like StreetComplete. Maybe you can check if it's like you proposed.

One question remains. In the OSM wiki it is stated that crossing=* is required for crossing:markings=*. (See https://wiki.openstreetmap.org/wiki/Key:crossing:markings) What's you opinion on that?

7h30n3 commented 7 months ago

Fixed in #242