search

OPEnSLab-OSU / Loom

Arduino library for Internet of Things Rapid Prototyping in environmental sensing
GNU General Public License v3.0
26 stars 3 forks source link

Test Loom_TSL2561 - Winnie #160

Closed winniiew closed 2 years ago

winniiew commented 2 years ago

TSL2561 failed to initialize

winniiew commented 2 years ago

[Device] Adding Module: Analog [TSL2561] Initialize failed [Device] Cannot add inactive module

Works with Adafruit library but not with Loom

udellc commented 2 years ago

The TSL 2561 is discontinued and no longer available to purchase anyways. We should retire this option in the code base.

lukegoertzen commented 2 years ago

I would disagree about removing this sensor module (or other working code not causing any harm). Even if it can't be purchased directly anymore, any existing hardware should still work just fine. Additionally, as an open source project, there may (perhaps unlikely) be people using the module still. It doesn't hurt to leave the sensor support code in the code base, other than perhaps compiled code size, but based on the nRF + sensor compile issues seen, the granularity of module enable sets should probably be reevaluated - e.g. perhaps add a deprecated sensor factory option.

lucasballr commented 2 years ago

We'll be removing this from the library, so no need to worry about this anymore.