ADS1115 Implementation is Broken

[prototypicalpro]

The ADS1115 implementation in Loom on master branch (https://github.com/OPEnSLab-OSU/Loom/blob/master/src/Sensors/I2C/ADS1115.h) produces incorrect values. After reviewing the implementation, I've found a number of errors that could be causing the issue:

• The ADS1115 constructor does not initialize several member variables which are later used to determine functionality. This could mean the bad outputs are a result of undefined behavior. The variables are declared at the top of the class: https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.h#L26-L41 Should be initialized in the constructor, but are not: https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L24-L26 And the undefined value may or may not be read in measure and package: https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L92-L94 https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L126-L132
• Two instances of the ADS1115 driver are created during initialization, which may be creating conflict and undefined behavior. The first one is declared as a class member as shown above, and the second one is declared during the initialization routine: https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L28-L29

Given the issues above, I've chosen to do a complete rewrite of the ADS1115 module. This rewrite should be available on master branch before the end of spring term.