Closed prototypicalpro closed 4 years ago
The ADS1115 implementation in Loom on master branch (https://github.com/OPEnSLab-OSU/Loom/blob/master/src/Sensors/I2C/ADS1115.h) produces incorrect values. After reviewing the implementation, I've found a number of errors that could be causing the issue:
measure
package
Given the issues above, I've chosen to do a complete rewrite of the ADS1115 module. This rewrite should be available on master branch before the end of spring term.
The ADS1115 implementation in Loom on master branch (https://github.com/OPEnSLab-OSU/Loom/blob/master/src/Sensors/I2C/ADS1115.h) produces incorrect values. After reviewing the implementation, I've found a number of errors that could be causing the issue:
measure
andpackage
: https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L92-L94 https://github.com/OPEnSLab-OSU/Loom/blob/69774fc770e311f572b5c293642a297e1d030526/src/Sensors/I2C/ADS1115.cpp#L126-L132Given the issues above, I've chosen to do a complete rewrite of the ADS1115 module. This rewrite should be available on master branch before the end of spring term.