search

OPEnSLab-OSU / Loom

Arduino library for Internet of Things Rapid Prototyping in environmental sensing
GNU General Public License v3.0
26 stars 3 forks source link

SleepyDog is included but not used, causing compilation errors #95

Closed prototypicalpro closed 4 years ago

prototypicalpro commented 4 years ago

Describe the bug The Adafruit SleepyDog library is included in Loom, but never used: https://github.com/OPEnSLab-OSU/Loom/blob/c5f7a950fa959fdf10c0a8a2875f87445dfd76d5/src/Sleep_Manager.cpp#L11-L15 https://github.com/OPEnSLab-OSU/Loom/blob/c5f7a950fa959fdf10c0a8a2875f87445dfd76d5/src/Sleep_Manager.cpp#L69-L77 I suspect SleepyDog was previously used but was removed during feature development.

As SleepyDog conflicts with FeatherFault (see https://github.com/OPEnSLab-OSU/FeatherFault/issues/5) which is needed by several projects in the lab, it would be nice if this dependency could be removed.

prototypicalpro commented 4 years ago

On second pass, I did find a place where SleepyDog is used: https://github.com/OPEnSLab-OSU/Loom/blob/49d1a5dba4bc0ff070ccce1bcf7e7348dd8846d5/src/Manager.cpp#L361-L371 Do projects in the lab use Loom::nap?

BGoto808 commented 4 years ago

Looking at the Github wikis for all of the projects, the only project I see that uses the Loom::nap function is Smartrock. However, when looking at their Github, they have a more recent code that they have for field testing that does not use the Loom::nap function. I would have to check in with them to see whether they are using the code that uses the Loom::nap function or the one without it.

https://github.com/OPEnSLab-OSU/SmartRock/blob/master/SmartRock2.5/SmartRock2.5.ino

akerr501 commented 4 years ago

SleepyDog has been removed from Loom with version 2.4.0. The nap function in Loom Manager has been moved outside to an example sketch that requires Adafruit SleepyDog to be downloaded outside of Loom, resolving any conflicts with FeatherFault