OPEnSLab-OSU / Spool

GNU General Public License v3.0
2 stars 1 forks source link

Bug with creating new Device inside a Network #25

Closed MrKangs closed 4 years ago

MrKangs commented 4 years ago

Describe the bug When you create a new device in an existing network, both old and new devices get deleted and unable to access those devices and data again.

Expected behavior Usually, it should have created a new device inside the network while having the old device information/data.

Hardware in Use None of the hardware was used for this issue. Mainly for the website.

To Reproduce Steps to reproduce the behavior:

  1. Go to Spool.open-sensing.org
  2. Go to Dashboard if you are logged in. If not, then log in to your account.
  3. Once you get into Dashboard, Register New Network if you don't have a network setup. Else, Click view a network.
  4. Click Register New Device
  5. Type any name and click Register Then you will see an empty network.

Screenshots image

This one the network before adding a new device.

image

This is after creating a new device into the network.

Desktop (please complete the following information):

Additional context At the same time, I believe that it should return a device id so that the user can add that information into the config. However, that is also not working as well.

Note I hope this issue/bug fixes as soon as possible because this is important for the documentation for Loom and Spool.

eliwinkelman commented 4 years ago

Thanks for making an issue for this Ken. This was caused by an issue with the new devices name being set to null, causing an issue when the frontend tries to list the devices. This should be fixed for new networks/devices now.