search

OPEnSLab-OSU / Spool

GNU General Public License v3.0
2 stars 1 forks source link

React app configuration is fixed at dockerfile build time #39

Closed eliwinkelman closed 4 years ago

eliwinkelman commented 4 years ago

Is your feature request related to a problem? Please describe. The config file for the react app is fixed when the dockerfile is built (for production). This essentially breaks the continuous delivery workflow and means that any other production spool instances would need to modify and rebuild the spool image just to change the client Auth0 tenant.

Describe the solution you'd like The configuration for the react app should be injected later in the build/deployment process. Preferably when the docker-compose is ran, based on a file outside of the docker image (since the docker image is fixed).

eliwinkelman commented 4 years ago

The problems associated with this issue were fixed for OPEnS Lab Continuous deployment in #41, however the issue of changing the environmental variables and rebuilding still apply to other users. In the future, we should move to injecting environmental variables on the server when sending the app html code, e.g. see https://create-react-app.dev/docs/title-and-meta-tags#injecting-data-from-the-server-into-the-page.