search

OPM / ResInsight

3D viewer and post processing of reservoir models
http://resinsight.org/
GNU General Public License v3.0
174 stars 92 forks source link

Binaries in GIT #13

Closed akva2 closed 11 years ago

akva2 commented 11 years ago

Nuff said. baaaad.

alfbr commented 11 years ago

Worse, git is discontinuing the downloads service. Hence, binaries will be hosted on opm-project.org in the near future.

rolk commented 11 years ago

I don't think Arne referred to downloadable end-binaries in the original issue; I don't see where those are, in that case. Please list which are (intermediate) binary files in the repository.

akva2 commented 11 years ago

i'm on about ThirdParty/Ert*

akva2 commented 11 years ago

imo these should be built as normal packages on linux, and downloaded using a dep downloader (i.e. a .bat) for windows.

rolk commented 11 years ago

@akva2 I agree about ThirdParty/Ert* (although note I am not a ResInsight developer); particularily since that package is available at GitHub at https://github.com/Ensembles/ert. IMO this could be a Git submodule, with ERT_ROOT_PATH (in ApplicationCode/CMakeLists.txt) being a cache value with default ../ThirdParty/ERT.

akva2 commented 11 years ago

submodule is an option. speaking from experience, submodules are a pain with git nubs around though - it's very easy to mess up the submodule state (git commit -a is not your friend..)

rolk commented 11 years ago

I agree that submodules are not the smoothest part of Git, but it seems to fit the bill here: The only commits in these directories are dumps at various checkpoints in ERT. Another option is of course to have it completely as an external library, as Qt is. We need a working ERT installation for opm-core also, so bona fide packages for ERT is right around the corner. :-)

JacobStoren commented 11 years ago

The ERT binary files in the ResInsight repository was an intermediate and pragmatic solution selected because ERT was originally hosted elsewhere in subversion. The build system was not quite streamlined, particularly for the use within ResInsight that only uses a small subset that is independent of other external libraries. So configuring and building ERT was done only when we needed to, for the only platform we needed to address. (RH5)

This will change. We are currently evaluating the options on how to include the Ert source and build system as a module within ResInsight. Suggestions are welcome.

ResInsight has not yet been made ready for packaging (as in rpm,deb) as the distribution has been limited to test users only on a very limited set of platforms where users have no root access.

akva2 commented 11 years ago

i have already supplied the beginnings of debian packaging for ERT (they were even pulled prematurely). still some issues left with having it as a system library, mainly naming conflicts (menu.h is not a good idea, libgeometry.so is not a good idea aso).

JacobStoren commented 11 years ago

Now the ERT library source code is embedded in the ResInsight Source tree, and the build systems are integrated. Hopefully this makes life easier.