search

OPM / opm-common

Common components for OPM, in particular build system (cmake).
http://www.opm-project.org
GNU General Public License v3.0
33 stars 111 forks source link

Allow non-zero ALQ without vfp tables (may be used in UDQs) #4324

Closed vkip closed 2 weeks ago

vkip commented 2 weeks ago

jenkins build this please

vkip commented 2 weeks ago

Just to be clear, this is trying to support the case of an ALQ being used in the defining expression of a UDQ, right?

Right.

It's not the other way around–i.e., a UDQ being used as a UDA for the ALQ?

No.

If so, then this looks mostly good to me although there are a couple of potential issues in the low-level details here. It's not ideal that glir() returns two different units of measurement though. The output system will perfom the correct unit conversion–i.e., no conversion at all–but the parameter will still be recorded in the SMSPEC and therefore labeled as a surface flow rate for gas in any production curve plots.

Good point, and didn't think of GGLIR/FGLIR.. Updated now.

bska commented 2 weeks ago

jenkins build this please