search

OPM / opm-core

Collection of utilities, solvers and other components.
http://www.opm-project.org
GNU General Public License v3.0
44 stars 50 forks source link

Read RS,RV,PRESSURE,SWAT,SGAS from EclipseState #1123

Closed jokva closed 7 years ago

jokva commented 7 years ago

Prefer reading these values from EclipseState rather than the Deck type.

jokva commented 7 years ago

Requires https://github.com/OPM/opm-parser/pull/1013

atgeirr commented 7 years ago

I should add: you can merge when done upstream and downstream, after testing (from opm-simulators).

jokva commented 7 years ago

How do I even do that now?

atgeirr commented 7 years ago

How do I even do that now?

I assumed that this API change needed a followup PR in opm-simulators, and that we would run Jenkins from there, but I was wrong about the followup need (as Travis shows). Therefore, merge when ready.

bska commented 7 years ago

Requires OPM/opm-parser#1013

Either that's incorrect or this PR was merged too soon. Which is it?

jokva commented 7 years ago

The former. The DENSITY use wasn't included in the completed patch (but I thought i branched out from there).

bska commented 7 years ago

Requires OPM/opm-parser#1013

Either that's incorrect or this PR was merged too soon. Which is it?

The former.

Okay. Thanks for the update.