search

OPM / opm-core

Collection of utilities, solvers and other components.
http://www.opm-project.org
GNU General Public License v3.0
44 stars 50 forks source link

changed: pass fipnum array into adaptive time stepping loop #1139

Closed akva2 closed 7 years ago

akva2 commented 7 years ago

needed as substep summary reports requires FIP data to be available. add calculation of this data if output is requested and summary config holds relevant keywords.

dr-robertk commented 7 years ago

Would it be possible to move the AdaptiveTimeStepping to opm-simulators (including history)? It's not used anywhere else and to would avoid having to have separate PR's all the time.

atgeirr commented 7 years ago

Would it be possible to move the AdaptiveTimeStepping to opm-simulators (including history)? It's not used anywhere else and to would avoid having to have separate PR's all the time.

Yes, and I agree we should do it. Will have a go as soon as I can find the time (probably not until next week).

akva2 commented 7 years ago

merging. permission granted in phone call with @atgeirr

atgeirr commented 7 years ago

Seems to compile without this, but to get the expected functionality this should be merged with OPM/opm-simulators#1046, so merging it now.

Edit: missing update on page lead me to believe this was not merged. Please ignore this comment.