search

OPM / opm-core

Collection of utilities, solvers and other components.
http://www.opm-project.org
GNU General Public License v3.0
44 stars 50 forks source link

Handle WEFAC #1188

Closed totto82 closed 6 years ago

totto82 commented 6 years ago

Added test combining WEFAC and GEFAC

Depends on OPM/opm-parser#1156

totto82 commented 6 years ago

jenkins build this with downstreams please

totto82 commented 6 years ago

Any reason for this not being merged?

atgeirr commented 6 years ago

Slipped my mind, not reviewed. @GitPaean can you take a look at it?

GitPaean commented 6 years ago

@totto82 , have you verified against ECL with a simulation? The keyword is not complicated, while it can be good to verify it before it goes in. Maybe you can add WEFAC to one or two wells in spe9group/SPE9_CP_GROUP.DATA in opm-data to protect this functionality.

totto82 commented 6 years ago

The keyword is not complicated

I am not sure if I agree. The interaction between efficiency factors and group control is hard to understand. I have tested the WEFAC alone without group control and it seems to work fine. When combined with group control it doesn't. I did have a look in the wellsGroup.pp and wellCollection.pp files but got lost...

GitPaean commented 6 years ago

Sorry about the misleading comments.

Would you like to share a result with modified spe9group/SPE9_CP_GROUP.DATA, so we can try to fix it together? I have never had a case with WEFAC, that is why it is not handled when implementing GEFAC.

If yes, I can try to modify the SPE9 case a little bit and send to you? Hopefully WEFAC does not conflict with GEFAC in a bad way.

And also, it is possible the group control is buggy.

totto82 commented 6 years ago

I have a test case that fails based on SPE9_GROUP. It is not the WEFAC <-> GEFAC interaction that is buggy. It is the WEFAC + Group controlled wells. I think WEFAC is supposed to be applied to the well production rate before summed for group rates. Lets discuss more on the hangout tomorrow.

GitPaean commented 6 years ago

I think WEFAC is supposed to be applied to the well production rate before summed for group rates. Lets discuss more on the hangout tomorrow.

Sure. There can be some tricky parts there. If the ECL result easy to understand, we can fix it to make the results straight.

totto82 commented 6 years ago

jenkins build this with downstreams please