search

OPM / opm-core

Collection of utilities, solvers and other components.
http://www.opm-project.org
GNU General Public License v3.0
44 stars 50 forks source link

Some fixes #1200

Closed andlaus closed 6 years ago

andlaus commented 6 years ago

these contains a few fixes for the some non-buildsystem issues that emerged during #1199.

andlaus commented 6 years ago

jenkins build this with downstreams please

andlaus commented 6 years ago

jenkins and even travis are happy with this. can it be merged?

dr-robertk commented 6 years ago

This patch seems ok from my side, especially the fixes in opm/core/linalg/LinearSolverPetsc.cpp and the UMFPACK file should be merged. After those are merged the "hack" in CMakeLists.txt which removes these files in case the packages are not found can be removed.

andlaus commented 6 years ago

After those are merged the "hack" in CMakeLists.txt which removes these files in case the packages are not found can be removed.

Okay, I've added a patch to this PR which does this...

andlaus commented 6 years ago

jenkins build this please

andlaus commented 6 years ago

@atgeirr: Jenkins and travis are happy and I'm quite sure that it fixes real shenangians. can it be merged?

dr-robertk commented 6 years ago

Seems like nobody is objecting and since this are fixes of real issues: Merging.