search

OPM / opm-grid

DUNE module supporting grids in a corner-point format
http://www.opm-project.org
GNU General Public License v3.0
20 stars 78 forks source link

Prepare OPM for DUNE 2.10 #758

Open blattms opened 1 month ago

blattms commented 1 month ago

DUNE_VERSION_NEWER has been removed. Falling back to DUNE_VERSION_GTE which exists since at least DUNE 2.7

Use Dune::Communcation instead of removed Dune::CollectiveCommunication (there since at least DUNE 2.7)l

blattms commented 1 month ago

jenkins build this please

blattms commented 1 month ago

Making this draft until i have a compiling version

timokoch commented 58 minutes ago

@blattms This has not made it into the 2024.10 release? So currently there is no version compatible with dune 2.10 right? Or can this is be backported?

bska commented 42 minutes ago

So currently there is no version compatible with dune 2.10 right?

Correct.

Or can this is be backported?

In my capacity as the release manager for the 2024.10 OPM release: It cannot as that would trigger a huge round of testing of the release packages. Dune 2.10 did not exist when we created the release branches for OPM 2024.10. Besides, the proper solution to the problem is arguably #745 (ping @akva2) and the other PRs listed in OPM/opm-common#4157.

On another note, I'm personally rather hesitant to declare "support" for Dune 2.10 since the OPM project has a stated policy of supporting the two most recent Ubuntu LTS releases (22.04 and 24.04 at the time of writing) and Dune 2.10 does not exist on either of those. In a sense OPM does not "need" Dune 2.10 until our 2026.04 release, although experience suggests we bring in some support for newer Dune releases earlier than that. It's a double-edged sword, though, because such support should really be backed by build testing as well which has a non-zero cost.