OPM / opm-grid

DUNE module supporting grids in a corner-point format
http://www.opm-project.org
GNU General Public License v3.0
19 stars 78 forks source link

On loadBalance(...) "addCornerCells" should be called "addEdgeCells"? #808

Open aritorto opened 5 days ago

aritorto commented 5 days ago

In an attempt to assign unique point ids on a distributed grid with LGRs, I invoked loadBalance, enabling the inclusion of cells that share corners with interior cells on each process by setting addCornerCells = true (one of the function arguments in loadBalance). However, instead of adding corner-sharing cells, this configuration primarily adds cells that share edges, in addition to the overlap layer of size 1. As a result, cells that share only a corner are not included, which can impact the uniqueness of point ids in certain cases.

In the test addLgrsOnDistributedGrid_test.cpp, both escenarios are included:

cases where setting addCornerCells=true fix the issue of unique point ids cases where setting addCornerCells=true is not enough to achieve unique point ids (cells that share only corners - and not edges - are not included).

Not relevant for the Reference Manual.

Replacement for OPM/opm-grid#806

aritorto commented 5 days ago

jenkins build this serial please

aritorto commented 33 minutes ago

jenkins build this serial please