search

OPM / opm-material

Provides thermodynamic relations, capillary pressure curves, etc.
Other
15 stars 51 forks source link

fixed: do not use Opm:: prefix when inside namespace Opm #458

Closed akva2 closed 3 years ago

akva2 commented 3 years ago

jenkins build this please

bska commented 3 years ago

There are a few more of these, e.g., in EclStone2Material.hpp. Do you want/need to address those too?

akva2 commented 3 years ago

need, no, they did not confuse the compiler, but i kinda want to yes.

bska commented 3 years ago

i kinda want to yes.

Okay. Do we hold off on merging this until you've addressed those or is the current PR sufficient to do what you want?

akva2 commented 3 years ago

i am already working on it but as I have work in queue waiting on this, it would be great if this can be merged first.

bska commented 3 years ago

i am already working on it but as I have work in queue waiting on this, it would be great if this can be merged first.

Very good. I'll merge this now.