search

OPM / opm-material

Provides thermodynamic relations, capillary pressure curves, etc.
Other
15 stars 51 forks source link

Fix conversion from density to bo #498

Closed totto82 closed 2 years ago

totto82 commented 2 years ago

Correctly account for dissolved CO2 in the conversion from density to bo

totto82 commented 2 years ago

This fixes a critical bug and should be ported to the release branch.

totto82 commented 2 years ago

jenkins build this please

totto82 commented 2 years ago

I guess the test failures are expected because of the changes?

Actually not, since it should not affect cases where rs = 0 I will do some more checking....

totto82 commented 2 years ago

I will do some more checking....

There seems to be a bug in the initialization code in master https://github.com/OPM/opm-simulators/pull/3871

totto82 commented 2 years ago

jenkins build this please

totto82 commented 2 years ago

Now the test failures are expected. I will update the ref.

totto82 commented 2 years ago

jenkins build this update_data please

blattms commented 2 years ago

jenkins build this opm-tests=749 please