search

OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
18 stars 67 forks source link

removing flashproperties.hh from multiple files #834

Closed GitPaean closed 1 year ago

GitPaean commented 1 year ago

it does not looks like it is used.

At least, flashboundaryratevector.hh can reused by other flash solvers directly after removing this header files. Others might need some adjustments before it can reused directly.

There might be some design here, but they can be added back anytime when needed. At least, with its current form, they are NOT used in anyway.

GitPaean commented 1 year ago

jenkins build this please

bska commented 1 year ago

There might be some design here, but they can be added back anytime when needed. At least, with its current form, they are used in anyway.

I wouldn't worry too much about it. No-one has touched this code in anger since commit ec918e30b. Whatever the initial intention might have been, the code has evolved in a different direction since then.

GitPaean commented 1 year ago

I wouldn't worry too much about it. No-one has touched this code in anger since commit https://github.com/OPM/opm-models/commit/ec918e30b3d1943a8d5e794396fd1f8607c2bd79.

Thanks for the comment. I will self-merge since it is relatively trivial.