search

OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
18 stars 67 forks source link

using GenericFluidSystem for co2ptflash problem #855

Closed GitPaean closed 9 months ago

bska commented 9 months ago

Closing this briefly to enable the CI system to pick up the force-pushed changes.

bska commented 9 months ago

Reopening this to test the build again.

lisajulia commented 9 months ago

@GitPaean: The commit 454c12c69ab39c535d1cb3f8415f8ee80a21e5fc causes some problems for me, i.e.

/opm/models/io/baseoutputmodule.hh:426:68: error: request for member ‘data’ in ‘Opm::H2OAirFluidSystem<double, Opm::TabulatedComponent<double, Opm::H2O<double>, true> >::phaseName(i)’, which is of non-class type ‘const char*’
  426 |             snprintf(name, 512, pattern, FluidSystem::phaseName(i).data())
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

Probably this commit is also involved: 0206bfa7dcf4a9360a37eb4bf2d73f903d289

Can you maybe have a look? Thanks! :)

blattms commented 9 months ago

There is one occurrence where we still return const char*: BaseFluidSystem.hpp#L77. Could that be problematic even though jenkins was fine?

GitPaean commented 9 months ago

There is one occurrence where we still return const char*: BaseFluidSystem.hpp#L77. Could that be problematic even though jenkins was fine?

That function should not be called. not totally sure.

GitPaean commented 9 months ago

@GitPaean: The commit 454c12c causes some problems for me, i.e.

/opm/models/io/baseoutputmodule.hh:426:68: error: request for member ‘data’ in ‘Opm::H2OAirFluidSystem<double, Opm::TabulatedComponent<double, Opm::H2O<double>, true> >::phaseName(i)’, which is of non-class type ‘const char*’
  426 |             snprintf(name, 512, pattern, FluidSystem::phaseName(i).data())
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

Probably this commit is also involved: 0206bfa7dcf4a9360a37eb4bf2d73f903d289

Can you maybe have a look? Thanks! :)

Can you tell a little bit more how I can reproduce it? Is your opm-common updated?

lisajulia commented 9 months ago

@GitPaean: Thanks, yes, my opm-common was not updated properly - sorry!