OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
17 stars 69 forks source link

Support for dynamic scaling of capillary pressure due to salt precipitation #860

Closed daavid00 closed 7 months ago

daavid00 commented 8 months ago

With https://github.com/OPM/opm-common/pull/3857, this PR adds support for dynamically scaling the capillary pressure as a result of porosity changes in salt precipitation. This is achieved by adding a multiplier using tables, as it is done for the permeability reduction (while the pcfact tables are set for each satnum region, the current implementation of permfact is defined via the pvtnum regions; this PR could changed that to satnum as well if it is of interest). An example of this functionality can be found in https://github.com/OPM/opm-tests/pull/1117. The Figure on the left corresponds to the resulting PC surface for that example and on the right the comparison for the salt precipitation in the bottom cell with and without this feature.

SALTPREC_PCFACT
totto82 commented 7 months ago

Thanks for the contribution. The PR is now ready for merging. Please consider adding the test case for regression.