search

OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
17 stars 69 forks source link

Construct the matrices in the AMG hierarchy with deterministic indices if possible. #864

Closed lisajulia closed 7 months ago

lisajulia commented 7 months ago

The function 'setUseFixedOrder' is called if it is defined and the matrices in the AMG hierarchy are constructed with deterministic indices. If its not defined yet, it is not called and the matrices in the AMG hierarchy are constructed with non-deterministic indices.

blattms commented 7 months ago

jenkins build this please

blattms commented 7 months ago

@lisajulia Now that you have the power you can call jenkins yourself.

blattms commented 7 months ago

I have one request. For the next version of release notes and manual, it would be good if there is a clear description what is accomplished by this PR. Maybe add something the the convergence rates and/or number of linear iterations differed for identical runs before and now these are reproducable with newer DUNE versions?

lisajulia commented 7 months ago

jenkins build this opm-simulators=5111 please

lisajulia commented 7 months ago

@bska should we run a benchmark here as well and then you can merge this PR?

akva2 commented 7 months ago

this code isn't used in any of the benchmarks.

blattms commented 7 months ago

What benchmark will do is to run the binary flow from opm-simulators with a view models and compare performance to previous runs.

Thanks a lot for the changes. I am merging them now.

blattms commented 7 months ago

@akva2 If I now broke the post-build then I owe you a beer. Should have checked whether jenkins was run...