search

OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
17 stars 69 forks source link

remove EWOMS_END_PARAM_REGISTRATION macro #884

Closed akva2 closed 5 months ago

akva2 commented 5 months ago

it adds no simplicity and only obfuscates

akva2 commented 5 months ago

jenkins build this opm-simulators=5269 please

blattms commented 5 months ago

Using the macro seems to indicate that we can now safely assume that all parameters are registered. E.g. to be sure that --help will print everything.

By removing it we cannot assume that at any stage. Might not really be a problem, though.

akva2 commented 5 months ago

That would be true if i did not replace the macro usage with the direct call instead....