search

OPM / opm-models

The models module for the Open Porous Media Simulation (OPM) framework
Other
17 stars 69 forks source link

Start separating (compile time) Properties from (runtime) Parameters #904

Closed akva2 closed 2 months ago

akva2 commented 2 months ago

Currently both of these use the Opm::Properties namespace. This causes confusion, and while they (currently) look somewhat similar on the surface the intended usage for these two beasts are quite different. To make things cleaner, more separate, and easier to change later on, I think we should move parameters to the Opm::Parameters namespace. This starts this journey by introducing this split for the FvBaseDiscretization properties.

akva2 commented 2 months ago

jenkins build this opm-simulators=5455 please

bska commented 2 months ago

Quick question for the purpose of review: I take it this PR must be merged in concert with the downstream PR OPM/opm-simulators#5455, right?

akva2 commented 2 months ago

Quick question for the purpose of review: I take it this PR must be merged in concert with the downstream PR OPM/opm-simulators#5455, right?

Correct

akva2 commented 2 months ago

jenkins build this opm-simulators=5455 please

akva2 commented 2 months ago

jenkins build this opm-simulators=5455 please

akva2 commented 2 months ago

jenkins build this opm-simulators=5455 please