OPM / opm-output

This repository is intended for output-writer functionality for the flow simulators in OPM
http://www.opm-project.org
GNU General Public License v3.0
3 stars 21 forks source link

Does opm-output need both ert and libecl? #192

Closed blattms closed 7 years ago

blattms commented 7 years ago

Somehow I was under the impression that opm should work without ert as libecl provides all that is needed? Is that assumption wrong?

With the version of May 26 I cannot buid opm-output if I only specify ECL_DIR and not ERT_ROOT:

jokva commented 7 years ago

No, it doesn't need ert at all, only ecl.

blattms commented 7 years ago

That might be but I have to tell it where ECL is via ERT_ROOT which is a bit confusing.

Here is may CMake options file without it:

set(METIS_ROOT "/home/mblatt/opt" CACHE STRING "metis home")
set(PARMETIS_ROOT "/home/mblatt/opt" CACHE STRING "parmentis home")
set(ECL_DIR "/home/mblatt/opt/libecl/share/cmake/ecl" CACHE STRING "ecl home")
set(DUNE_ROOT         "/home/mblatt/DUNE-test" CACHE STRING "Path to dune")
set(USE_MPI ON         CACHE STRING "Use mpi")
set(PTSCOTCH_ROOT "/home/mblatt/opt" CACHE STRING "Path to PTSCOTCH")
set(ZOLTAN_ROOT "/home/mblatt/opt" CACHE STRING "Path to ZOLTAN")
set(BUILD_TESTING OFF CACHE BOOL "Build tests")

opm-output version seems new:

mblatt@loft11004:~/DUNE-test/opm-output$ git log -1
commit b5d8b43d12f83177b6207237480c64c6b7667acb
Merge: fbb34c5 9001c8f
Author: Joakim Hove <joakim.hove@gmail.com>
Date:   Fri Jun 2 13:04:57 2017 +0200

    Merge pull request #189 from joakim-hove/empty-region

    Will write (incorrect) TCPU to summary files.

Still I get an error with out passing a location for ERT:

-- Finding package ERT using module mode
CMake Error at /usr/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:136 (message):
  Could NOT find ERT (missing: ERT_INCLUDE_DIR ERT_LIBRARY)
Call Stack (most recent call first):
  /usr/share/cmake-3.0/Modules/FindPackageHandleStandardArgs.cmake:343 (_FPHSA_FAILURE_MESSAGE)
  /home/mblatt/DUNE-test/opm-common/cmake/Modules/FindERT.cmake:189 (find_package_handle_standard_args)
  /home/mblatt/DUNE-test/opm-common/cmake/Modules/OpmFind.cmake:147 (find_package)
  /home/mblatt/DUNE-test/opm-common/cmake/Modules/OpmFind.cmake:211 (find_and_append_package_to)
  /home/mblatt/DUNE-test/opm-common/cmake/Modules/OpmLibMain.cmake:112 (find_and_append_package_list_to)
  CMakeLists.txt:101 (include)

I do have to pass -DERT_ROOT=/home/mblatt/opt/libecl to cmake for this error to vanish.

jokva commented 7 years ago

Have you updated opm-common as well? All references to ERT should be gone.

blattms commented 7 years ago

Thanks and sorry for the noise. That one was not update (such a rookie mistake...).

Additionally, I was setting ECL_DIR instead of ecl_DIR as I should have.