search

OPM / opm-output

This repository is intended for output-writer functionality for the flow simulators in OPM
http://www.opm-project.org
GNU General Public License v3.0
3 stars 21 forks source link

Fix FPR and RPR for 2p GasOil case #218

Closed totto82 closed 6 years ago

joakim-hove commented 6 years ago

Personally I would do something like: 

if (args.state.has("SWAT")) {
    const auto& swat = args.state.data("SWAT");
    for (size_t i = 0; i < p.size(); i++)
          hcs += pv[i] * (1 - swat[i])
} else {
    for (size_t i; i < p.size(); i++)
         hcs += pv[i];
}

but if you prefer your variety I will merge that.

What about the test failure downstream?

totto82 commented 6 years ago

What about the test failure downstream?

Strange SPE5 doesn't even output FPR.

totto82 commented 6 years ago

SPE5 fails for everybody. I guess we should blame: OPM/ewoms#219

atgeirr commented 6 years ago

jenkins build this with downstreams please