WIP:Include efficiency factor

[sveinung-r]

Efficiency factors are multiplied when specified at multiple levels of the well/group hierarchy.

The factors are included as follows:

• Well Rate (e.g. WOPR) - No efficiency factor
• Well Total (e.g. WOPT) - WEFAC & GEFAC (whole hierarchy)
• Group Rate (e.g. GOPR) - WEFAC & GEFAC (only subgroups)
• Group Total (e.g. GOPT) - WEFAC & GEFAC (whole hierarchy)
• Field Rate (e.g. FOPR) - WEFAC & GEFAC (whole hierarchy)
• Field Total (e.g. FOPT) - WEFAC & GEFAC (whole hierarchy)
• Region Rate (e.g. ROPR) - WEFAC & GEFAC (whole hierarchy)
• Region Total (e.g. ROPT) - WEFAC & GEFAC (whole hierarchy)

Ref #236

[totto82]

Thanks. I have tested this and can verify that it fixes my issue i.e #236.

[alfbr]

WEFAC is not implemented correctly. I can communicate the issue directly.

[totto82]

WEFAC is not implemented correctly. I can communicate the issue directly.

Could you enlighten me on the issue as well?

[alfbr]

Sure, but I am not sure I have time before the weekend.

[joakim-hove]

@alfbr:

WEFAC is not implemented correctly. I can communicate the issue directly.

Is this a review comment for the current PR?

[joakim-hove]

The WEFAC functionality is quite weird - it would be beneficial (also for the reviewer ...) if you could explain the principles in a comment.

[GitPaean]

My two cents, the well rate is an instantaneous rate, so WEFAC will not impact the RATE. WEFAC is to handle the downtime, basically it means the Well is not operating full time, maybe 80% of the time (20% downtime, WEFAC=0.8) .

I do not see anything obviously wrong in the description in the PR.

[lars-petter-hauge]

The well and the group efficiency factors, as @GitPaean describes, provide means do incorporate downtime/maintenance time for wells, without changing the rates explicitly.

It will not impact the well rate itself, but is rather applied for accumulated values. The WEFAC can be considered to shut and open the well for short intervals within the same timestep, and the well is therefore solved at full speed. When WEFAC is set to 0.8 for all wells in a group, it is considered that every well is flowing at full speed, but only 80% of them are flowing at any given time. The rate of a group therefore takes into account well efficiency factors.

Groups are treated similarly as wells. The group's GEFAC is not applied for rates, only for accumulated volumes. When GEFAC is set to 0.8 for a group, it is considered that all wells are taken down simultaneously, and GEFAC is therefore not applied to the group's rate. However, any efficiency factors applied to the group's wells or sub-groups must be included.

Regions and fields will have the well and group efficiency applied for both rates and accumulated values.

[atgeirr]

Thanks for the explanation @lars-petter-hauge!

[joakim-hove]

@lars-petter-hauge : Thank you for a good explanation; since this feature is quite weird I would actually like a comment in the code - essentially an excerpt of what you have written here.

[joakim-hove]

Some minoor comments - then this is ready to be merged (when rebased!)

[joakim-hove]

jenkins build this please

[joakim-hove]

jenkins build this update_data please

[joakim-hove]

jenkins build this opm-data=308 please