OPM / opm-output

This repository is intended for output-writer functionality for the flow simulators in OPM
http://www.opm-project.org
GNU General Public License v3.0
3 stars 21 forks source link

adding a few summary keywords #253

Closed GitPaean closed 6 years ago

GitPaean commented 6 years ago

WWVIR, WGVPR and WGVIR. It depends on OPM/opm-parser#1211

I am not sure why the test fails, maybe the maintainer can help to give some hints about it.

test 7
    Start 7: test_Summary

7: Test command: /home/kaib/OPM-PR-test/debug/opm-output-build/bin/test_Summary
7: Test timeout computed to be: 1500
7: 
7: Error message: ecl_sum_tstep_iget: param index:-1 invalid: Valid range: [0,654) 
7: 
7: See file: /tmp/ert_abort_dump.kaib.20180213-162937.log for more details of the crash.
7: Setting the environment variable "ERT_SHOW_BACKTRACE" will show the backtrace on stderr.
7: Running 14 test cases...
1/1 Test #7: test_Summary .....................***Exception: Other  0.27 sec
GitPaean commented 6 years ago

More information

test 7
    Start 7: test_Summary

7: Test command: /home/kaib/OPM-PR-test/debug/opm-output-build/bin/test_Summary
7: Test timeout computed to be: 1500
7: 
7: 
7: Abort called from: ecl_sum_tstep_iget (/home/kaib/OPM-devel-test/libecl/lib/ecl/ecl_sum_tstep.c:241) 
7: 
7: Error message: ecl_sum_tstep_iget: param index:-1 invalid: Valid range: [0,654) 
7: 
7: 
7: 
7: --------------------------------------------------------------------------------
7:  #00 util_abort__(..)                                                              in ???
7:  #01 ecl_sum_tstep_iget(..)                                                        in ???
7:  #02 _ZN13well_keywords11test_methodEv(..)                                         in ???
7:  #03 ???(..)                                                                       in /home/kaib/OPM-PR-test/debug/opm-output/tests/test_Summary.cpp:209
7:  #04 _ZN5boost9unit_test9ut_detail16callback0_impl_tINS1_6unusedEPFvvEE6invokeEv(..)    in /usr/include/boost/test/utils/callback.hpp:89
7:  #05 ???? 
7:  #06 _ZN5boost17execution_monitor13catch_signalsERKNS_9unit_test9callback0IiEE(..)    in ???
7:  #07 _ZN5boost17execution_monitor7executeERKNS_9unit_test9callback0IiEE(..)        in ???
7:  #08 _ZN5boost9unit_test19unit_test_monitor_t21execute_and_translateERKNS0_9test_caseE(..)    in ???
7:  #09 _ZN5boost9unit_test14framework_impl5visitERKNS0_9test_caseE(..)               in ???
7:  #10 _ZN5boost9unit_test18traverse_test_treeERKNS0_10test_suiteERNS0_17test_tree_visitorE(..)    in ???
7:  #11 _ZN5boost9unit_test9framework3runEmb(..)                                      in ???
7:  #12 _ZN5boost9unit_test14unit_test_mainEPFbvEiPPc(..)                             in ???
7:  #13 __libc_start_main(..)                                                         in /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325
7:  #14 _start(..)                                                                    in ???
7: --------------------------------------------------------------------------------
7: Running 14 test cases...
joakim-hove commented 6 years ago

I will get back to you

joakim-hove commented 6 years ago

I am not sure why the test fails, maybe the maintainer can help to give some hints about it.

Well - the faulure is of course quite hard; but happens is that the summary object you have generated - and then loaded from disk, does not have the relevant keywords. And that again is because you have not asked for those keywords, and that again is because they are not (yet) internalized in opm-parser. With this PR you have instructed the opm-output layer how to calculate these vectors, but opm-parser does not recognize these keywords and therefor you will never ask for them - even you now know how to calculate them. When building with OPM/opm-parser#1211 I assume things will work.

joakim-hove commented 6 years ago

jenkins build this opm-parser=1211 please

GitPaean commented 6 years ago

The error was reproduced on Jenkins.

 6/12 Test  #6: test_RFT .........................   Passed    0.07 sec
      Start  7: test_Summary
 7/12 Test  #7: test_Summary .....................***Exception: Other  0.32 sec
      Start  8: test_Tables
 8/12 Test  #8: test_Tables ......................   Passed    0.08 sec
      Start  9: test_Wells
 9/12 Test  #9: test_Wells .......................   Passed    0.01 sec
      Start 10: test_writenumwells
10/12 Test #10: test_writenumwells ...............   Passed    0.03 sec
      Start 11: test_Solution
11/12 Test #11: test_Solution ....................   Passed    0.01 sec
      Start 12: test_regionCache
12/12 Test #12: test_regionCache .................   Passed    0.03 sec

92% tests passed, 1 tests failed out of 12

Total Test time (real) =   0.80 sec

The following tests FAILED:
      7 - test_Summary (OTHER_FAULT)
GitPaean commented 6 years ago

Fixed locally. I need to add the keywords to the summary section in the DATA file. Thanks for the suggestion.

GitPaean commented 6 years ago

jenkins build this opm-parser=1211 please

GitPaean commented 6 years ago

I am not able to trigger Jenkins in this repo. @joakim-hove you can help to that. It was tested locally.

joakim-hove commented 6 years ago

jenkins build this opm-parser=1211 please

joakim-hove commented 6 years ago

I need to add the keywords to the summary section in the DATA file.

Yes - if you want them in the output you have to ask for them; that kind of goes without saying?

GitPaean commented 6 years ago

A question here. Any idea how to check if these three keywords WWVIR, WGVPR and WGVIR, and also other related to the total voidage rates keywords (the keywords like GVIT, GVPR .. ) requested? Basically, it provides some idea which well is requested to output the voidage related rates, so we will calculate the corresponding reservoir rate.

It is needed at least in the WellModel level, possibly used in each well level. Please suggest how to do it. Thanks. I tried to track up from the Simulator, while it did not look like trivial. Some suggestions will very helpful.

GitPaean commented 6 years ago

It can be more general, we need to check if some quantities need to be output to the summary file to decide if we will compute them.

joakim-hove commented 6 years ago

If I understand your question correctly the answer is to query the SummaryConfig object from the parser.

GitPaean commented 6 years ago

If I understand your question correctly the answer is to query the SummaryConfig object from the parser.

Thanks, this is very helpful. I will check how SummaryConfig is used in the Simulator side.

joakim-hove commented 6 years ago

jenkins build this please