search

OPM / opm-parser

http://www.opm-project.org
11 stars 44 forks source link

Added one-argument ParseContext constructor. #1164

Closed joakim-hove closed 6 years ago

joakim-hove commented 6 years ago

jenkins build this with downstreams please

atgeirr commented 6 years ago

Just one thing: one-argument constructors should be explicit unless you specifically want to have implicit conversion.

joakim-hove commented 6 years ago

Just one thing: one-argument constructors should be explicit unless you specifically want to have implicit conversion.

Ehhh - well; it is marked as explicit in the header file.

atgeirr commented 6 years ago

Ehhh - well; it is marked as explicit in the header file.

Yes of course! Sorry for the noise, I must have looked at the cpp file and not noticed.

andlaus commented 6 years ago

Ehhh - well; it is marked as explicit in the header file.

Yes of course! Sorry for the noise, I must have looked at the cpp file and not noticed.

did you just deliver an argument that all function bodies should go beneath their declarations? ;)