fix the TEMPI property if it is initialized using RTEMPVD

OPM / opm-parser

http://www.opm-project.org

11 stars 44 forks source link

fix the TEMPI property if it is initialized using RTEMPVD #1171

Closed andlaus closed 6 years ago

andlaus commented 6 years ago

this is another episode of the saga of energy support: E100 seems to silently use equil region zero if EQLNUM was not specified, and the data contained in the EQLNUM array uses fortran-style indices.

joakim-hove commented 6 years ago

jenkins build this with downstreams please

joakim-hove commented 6 years ago

OK Andreas; I give up - this was more messy than I thought. Polish/rename as you like and I will merge.

andlaus commented 6 years ago

this was more messy than I thought

join the club ;)

I was quite surprised that I got NaNs in TEMPI wen RTEMPVD was used. because the patch itself is pretty simple, I would declare it merge-ready from my side.

andlaus commented 6 years ago

can this be merged? the reservoir temperature of thermal case of OPM/opm-data#289 is currently NaN because of this. (you need to modify flow a bit to even get to that stage.)

joakim-hove commented 6 years ago

can this be merged?

Yes