Aquancon object - Githubissues

OPM / opm-parser

http://www.opm-project.org

11 stars 44 forks source link

Aquancon object #1190

Closed nairr closed 6 years ago

nairr commented 6 years ago

An Aquancon object which:

collects information from the AQUANCON keyword,
converts the grid box information into global indices
converts the per record information of AQUANCON into per Aquifer information
Applies certain logic for connecting grid cells to aquifers
returns an output vector with information of aquifer id, global index, cell face, influx coefficient and influx multiplier

nairr commented 6 years ago

I've made the requested changes with the latest commit

joakim-hove commented 6 years ago

OK - then you are just missing some basic tests of this class, and it is ready to be merged.

nairr commented 6 years ago

The tests should be in now. Thanks for helping me out through this!

joakim-hove commented 6 years ago

jenkins build this with downstreams please

joakim-hove commented 6 years ago

OK - some minor C++ comments on the test; then this is ready to be merged. But I must admit I really don't like the approach with multiple aquifer connections in one struct. Before I merge - could you point me to the downstream code using this - that the current approach is more convenient there will be the main argument to merge the current approach.

kel85uk commented 6 years ago

Hi @joakim-hove , sure. It's located here https://github.com/kel85uk/opm-simulators/blob/task/%235/Make_correct_initialization_procedure/opm/autodiff/BlackoilAquiferModel_impl.hpp at the init function

nairr commented 6 years ago

cleaned up the test

joakim-hove commented 6 years ago

jenkins build this with downstreams please