search

OPM / opm-parser

http://www.opm-project.org
11 stars 44 forks source link

[WIP] Support WSEGSICD #1194

Closed GitPaean closed 6 years ago

GitPaean commented 6 years ago

The support of keyword WSEGSICD.

The test towards the major model is not done yet, and there might be something needs to be adjusted / improved, so it is marked WIP.

joakim-hove commented 6 years ago

Thank you for writing test code.

joakim-hove commented 6 years ago

jenkins build this with downstreams please

GitPaean commented 6 years ago

Just added a member variable to Completion for its length. As far as I know, the places can make use of this information is the shear calculation in polymer simulation, the current ICD implementation and some other incoming development related to well modeling. Not sure how it will be bitten by the pinching during the grid processing though. Please let me know there are more things in the tests needed to be addressed for this completion length. There are so many tests related to Completion, it is difficult to get all of them correctly.

GitPaean commented 6 years ago

jenkins build this please

GitPaean commented 6 years ago

jenkins build this please

GitPaean commented 6 years ago

Jenkins build this please

GitPaean commented 6 years ago

Jenkins build this please

joakim-hove commented 6 years ago

I am ready to merge this - but it is still marked as WIP?

akva2 commented 6 years ago

just note that any merges done to parser or output means i will have to redo https://github.com/OPM/opm-common/pull/341 (mostly automated but...)

GitPaean commented 6 years ago

I am ready to merge this - but it is still marked as WIP?

It has not been well tested against the major model we are targeting, so it is still WIP.

just note that any merges done to parser or output means i will have to redo OPM/opm-common#341 (mostly automated but...)

I understand that. It is okay to me to create a new pull request in the new opm-common repo.

atgeirr commented 6 years ago

just note that any merges done to parser or output means i will have to redo OPM/opm-common#341 (mostly automated but...)

While we cannot "move" PRs I think it is ok to require reopening the PR against the new repo. Agree?

atgeirr commented 6 years ago

This PR must be moved to the opm-common module, following the recently merged reorganization.