search

OPM / opm-parser

http://www.opm-project.org
11 stars 44 forks source link

rename c_p to c_v in specrock and specheat table classes #1200

Closed andlaus closed 6 years ago

andlaus commented 6 years ago

even though the official documentation does not seem to specify whether the specified heat capacities of the SPECROCK and SPECHEAT keywords are for constant pressure or for constant volume, the implicitly seem to be for the latter: pressure dependent heat capacites cannot be specified, yet the enthalpy for an incompressible fluid is pressure dependent, so the specified heat capacities must be for constant volume and they specify the internal energy instead of the enthalpy.

this requires some downstream mop-up in opm-material. permission to merge the downstream PR with this one is hereby granted.

andlaus commented 6 years ago

jenkins build this with downstreams opm-material=282 please

andlaus commented 6 years ago

the travis and appveyor error are quite surely bogus because their configuration files have been removed recently IIRC. @joakim-hove: are the integrations for these services still active for this repository?

joakim-hove commented 6 years ago

@joakim-hove: are the integrations for these services still active for this repository?

No - I am trying my best to disable them; but I do not have the necessary credentials. Some more nagging is required: @jepebe