OPM / opm-parser

http://www.opm-project.org
11 stars 44 forks source link

adding a few summary keywords #1211

Closed GitPaean closed 6 years ago

GitPaean commented 6 years ago

WOVPT, WOVIR, WOVIT, WWVPR, WWVPT, WWVIR, WWVIT, WGVPR, WGVPT, WGVIR, WGVIT

basically they are the keywords for reservoir phase rates summary output.

I guess to output them with OPM, we need to add them in opm-output and do more things in opm-simulators. I am not sure how the summary keyword system works, please correct me if I am wrong.

How to add the related FIELD and GROUP keywords? Do we need to do them in opm-parser, or just in opm-output?

GitPaean commented 6 years ago

jenkins build this please

joakim-hove commented 6 years ago

I guess to output them with OPM, we need to add them in opm-output and do more things in opm-simulators.

This is correct.

joakim-hove commented 6 years ago

How to add the related FIELD and GROUP keywords?

You need to add them to the FIELD_PROBE and GROUP_PROBE keywords, just like you have done with the WELL_PROBE keyword already. And then subsequently updates to opm-output.

I am happy to merge this now; but I will leave it open in case you want to add the corresponding FIELD and GROUP keywords?

GitPaean commented 6 years ago

I am happy to merge this now; but I will leave it open in case you want to add the corresponding FIELD and GROUP keywords?

Please leave it open and I will add the FIELD and GROUP related keywords later today. I did not find these two files when I created this PR.

GitPaean commented 6 years ago

The things are little more messy to me now. It looks like a lot of keywords are only available for E100 while not E300. All the related keywords in FIELD and GROUP are not available for E100. So the new commit message is

add WWVIR, WGVPR and WGVIR, and removing WOVPR

the commit has been updated.

GitPaean commented 6 years ago

jenkins build this please

GitPaean commented 6 years ago

jenkins build this please

GitPaean commented 6 years ago

I am done updating this PR. Merge anytime you want.

joakim-hove commented 6 years ago

Ok - I will, busy today though.