Fixed ignored keywords

[hakonhagland]

See #52 for background. Used the script in #148 to fixup ignored keywords.

[hakonhagland]

I can see some problems. For example 10.3/AQUFET.fodt, here the script should not replace the whole "p" tag, but instead needs to check for the sub statement within the "p" tag: "This keyword is ignored by OPM Flow and has no effect on the simulation;" or else it will delete text that it should not delete.

I will try to find a workaround for these issues

[hakonhagland]

Another special case: 10.3/DEBUG.fodt here the "p" tag also includes additional text that should not be deleted. The script needs to look for the sub text "it is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness."

[hakonhagland]

Another special case: 12.3/ACTION.fodt . This is similar to 10.3/AQUFET.fodt

[gdfldm]

The script needs to look for the sub text "it is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness."

@hakonhagland I think we should just replace "is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness." (without the "it") then we should be able to catch phrases starting "it is ignored..." and "The keyword is ignored...".

[hakonhagland]

@gdfldm I just updated the script to handle these two special cases. Can you see any more special cases it should handle?

[gdfldm]

@hakonhagland how about DR etc. "Currently this keyword is ignored by OPM Flow and has no effect on the simulation; however one can us the vector form of the keyword, DRV, to enter the data instead."?

[gdfldm]

@hakonhagland, this case DRSDTR might not be handled "This keyword is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness, as it is expected to be available in the next release of OPM Flow." But I think it is the only one so could be done by hand.

[gdfldm]

@hakonhagland there is also LICENSES/MULTREAL "OPM Flow is an open source project and therefore there is no license management of the various implemented options; hence, this keyword is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness.". But again these are just a few cases that could be done by hand?

[hakonhagland]

But again these are just a few cases that could be done by hand?

@gdfldm Yes, if it is only these 3 keywords I think it would be better to them by hand.

[hakonhagland]

@gdfldm I changed the script a little bit to handle these cases. Can you check if it looks ok?

[hakonhagland]

Seems like the script now handles "This keyword is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness." with a trailing "." the same way as with a trailing ",". Which gives results like 10.3/APIVD.fodt which we do not want, right?

I will try to fix this.

[gdfldm]

Can you check if it looks ok?

Great the new script handles these cases. Thank you :)

[hakonhagland]

Seems like the script now handles "This keyword is ignored by OPM Flow and has no effect on the simulation but is documented here for completeness." with a trailing "." the same way as with a trailing ",". Which gives results ... which we do not want

Updated script again to fix this.

[gdfldm]

@hakonhagland that looks great. I have scanned through and haven't spotted any unhandled cases. Thank you!

[blattms]

@hakonhagland that looks great. I have scanned through and haven't spotted any unhandled cases. Thank you!

Then my concern in #148 is probably unfounded. That's great!

[hakonhagland]

Resubmitted as #152.