search

OPM / opm-reference-manual

Other
1 stars 5 forks source link

add-keyword script creates messy diffs #228

Open blattms opened 3 months ago

blattms commented 3 months ago

If I do (my intention was to show how clean the diff of the other files is :sweat_smile: ):

$ git reset --hard HEAD
$ fodt-add-keyword --maindir=../parts --keyword=HELLO --section=4.3 --title="Hello World" --status=green

the diff looks a bit messy. Seems like the script changes A.fdot by reintroducing closing tags, e.g.:

-   <config:config-item config:name="PrinterSetup" config:type="base64Binary"/>
+   <config:config-item config:name="PrinterSetup" config:type="base64Binary"></config:config-item>

Not sure where this comes from. I thought we actually changed that.

hakonhagland commented 3 months ago

Yes I think we have not fixed the add-keyword script to handle empty tags yet. I will try to fix the script.