search

OPM / opm-reference-manual

Other
1 stars 5 forks source link

Fixed bug in the run docker container script #255

Open hakonhagland opened 4 months ago

hakonhagland commented 4 months ago

For background see https://github.com/OPM/opm-reference-manual/pull/208#issuecomment-2134838443.

The git root will not always be 3 levels up from the filename. Added a more advanced method to find the git root. Also added a test case.

blattms commented 4 months ago

With this, can I call the scripts anywhere? I had the impression that there even have been assumptions where the venv directory was created. Seemed like it had to be created below scripts/python

While I would have created it directly in the root directory.

hakonhagland commented 4 months ago

Seemed like it had to be created below scripts/python

@blattms Yes, I tried now with "pip install ./docker" from the root directory, and there seems to be some assumptions in the script about the current directory being "\<root>/docker" when running the docker python scripts. I will check what is going on.

hakonhagland commented 4 months ago

@blattms I have updated the script such that the user can do "pip install ./docker" from the root directory of the git repository or from anywhere he likes (instead of first cwd to docker and then do "pip install ."). Can you retest?